feat(elasticache): connection details for elasticache (memcached only) - #1440
Merged
turkenf merged 4 commits intoAug 6, 2024
Merged
Conversation
aiell0
requested review from
mbbush,
sergenyalcin,
turkenf and
ulucinar
as code owners
August 3, 2024 18:23
Signed-off-by: aiell0 <lawrence@rogodata.com>
Signed-off-by: aiell0 <lawrence@rogodata.com>
Signed-off-by: aiell0 <lawrence@rogodata.com>
aiell0
force-pushed
the
connection-details-elasticache
branch
2 times, most recently
from
August 5, 2024 01:49
b3baa89 to
b8b071c
Compare
Collaborator
|
/test-examples="examples/elasticache/v1beta1/cluster.yaml" Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/10249206747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Implements #1431
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
I ran a
make upteston my own AWS EKS cluster on the example that was modified as part of this PR, and the cluster address was properly printed.